Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Feb 3, 2024
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=101

@bors
Copy link
Collaborator

bors commented Feb 3, 2024

📌 Commit 8ef369b has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 3, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2024
@bors
Copy link
Collaborator

bors commented Feb 3, 2024

⌛ Testing commit 8ef369b with merge b11fbfb...

@bors
Copy link
Collaborator

bors commented Feb 3, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing b11fbfb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 3, 2024
@bors bors merged commit b11fbfb into rust-lang:master Feb 3, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 3, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b11fbfb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.9% [-3.5%, -0.8%] 19
Improvements ✅
(secondary)
-2.6% [-3.6%, -0.7%] 38
All ❌✅ (primary) -1.9% [-3.5%, -0.8%] 19

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.8% [5.3%, 7.9%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.7% [-8.1%, -2.0%] 4
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 662.752s -> 659.957s (-0.42%)
Artifact size: 308.09 MiB -> 308.08 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants